add tarot universe meropis exits #201
Conversation
There was a problem hiding this comment.
This will work, but I'm not quite happy with the implementation. If you don't know what I mean, please ignore this comment and we will merge this in a few days. If you do and find the comment useful, feel free to implement it or comment that you would like to do so.
There are two things that make me unhappy. First, the actual creation of the special exits is duplicated. And second, every time a new path is calculated, one of the two tables is created from scratch. This probably doesn't matter for modern computers, but still...
You could get rid of both things by pulling the table out if the function and into the script proper, using two subtables:
local tarot locations = {
Main = { ...},
Meropis = { ... }
}Then in the actual function, just check, if the subtable for the current continent exists and if it does, run the code to add the temp special exits.
| yggdrasil = 12207, | ||
| } | ||
| for village, roomnum in pairs(tarotLocations) do | ||
| local continent = mmp.getareacontinents(area)[1] |
There was a problem hiding this comment.
I really don't like this one, but I figured the way mmp.oncontinent is implemented, at some point someone agreed for Achaea special exits to not care for multiple continent areas. Or maybe I'm missing something
|
I don't have someone to test this at the moment, also I would like an input on my comment |
added temporary exits for the tarot universe skill that were missing. previously mapper would only use the ability on mainland