Skip to content

WIP: Is7510/catalog service refactor #7546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 16, 2025

What do these changes do?

  • Splits background task scheduling from syncronization logic
  • uses exclusive_periodic which requires redis locks

Related issue/s

How to test

Dev-ops

None

@pcrespov pcrespov self-assigned this Apr 16, 2025
@pcrespov pcrespov added the a:catalog catalog service label Apr 16, 2025
@pcrespov pcrespov added this to the Pauwel Kwak milestone Apr 16, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 87.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 86.70%. Comparing base (0137533) to head (21b0759).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7546      +/-   ##
==========================================
- Coverage   87.48%   86.70%   -0.79%     
==========================================
  Files        1743     1738       -5     
  Lines       67495    67365     -130     
  Branches     1144     1146       +2     
==========================================
- Hits        59049    58408     -641     
- Misses       8125     8635     +510     
- Partials      321      322       +1     
Flag Coverage Δ
integrationtests 56.43% <ø> (-8.80%) ⬇️
unittests 86.66% <87.00%> (-0.01%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.91% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 92.00% <ø> (+<0.01%) ⬆️
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.18% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.75% <98.14%> (+0.21%) ⬆️
pkg_settings_library 90.82% <100.00%> (+0.02%) ⬆️
pkg_simcore_sdk 85.40% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.26% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.96% <72.72%> (-0.56%) ⬇️
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.87% <ø> (+0.09%) ⬆️
director_v2 84.46% <ø> (-6.84%) ⬇️
dynamic_scheduler 97.40% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.02% <ø> (-0.17%) ⬇️
storage 87.52% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 85.70% <ø> (-0.33%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0137533...21b0759. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:catalog catalog service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background task: upgrade and add i/o in database? Catalog periodic error
1 participant