Skip to content

default besselh to k=1 like the docs say it does #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

oscardssmith
Copy link
Member

The docs say besselh(nu, [k=1,] x) so if the user calls a 2 arg version of this, they are asking for k=1.

@oscardssmith oscardssmith requested a review from heltonmc April 24, 2025 02:17
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.71%. Comparing base (ec6c51d) to head (f1427e9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files          24       24           
  Lines        2382     2383    +1     
=======================================
+ Hits         2280     2281    +1     
  Misses        102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@heltonmc heltonmc merged commit c6e3777 into master Apr 25, 2025
4 of 7 checks passed
@oscardssmith oscardssmith deleted the os/besselh-default-k branch April 25, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants