Skip to content

Do not promote mean and covariance of MvNormal to common element type #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

devmotion
Copy link
Member

Ref #1964. Currently just to see if and what it would break.

@hersle
Copy link

hersle commented Apr 11, 2025

Thanks for giving it a go!

How bad is this? I can imagine several of these test failures are fixable.

What really matters at the end of the day? That the core API functions are type-stable and respect eltype?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.24%. Comparing base (f33cc10) to head (12241fe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1965      +/-   ##
==========================================
- Coverage   86.26%   86.24%   -0.02%     
==========================================
  Files         146      146              
  Lines        8763     8762       -1     
==========================================
- Hits         7559     7557       -2     
- Misses       1204     1205       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hersle
Copy link

hersle commented Apr 16, 2025

Is this good to merge, or are there more things to consider?

@devmotion
Copy link
Member Author

No, this is a major change, so it requires a bit more discussion, feedback from other maintainers, and should in the end be approved by another maintainer.

I'm also not sure yet whether the workaround for UniformScaling is desirable; maybe that codepath should be deprecated completely in favour of FillArrays.Eye which in contrast to UniformScaling has a clearly defined size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants