Skip to content

Adopt KUP requirements imposed by KT-75078 #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fzhinkin
Copy link
Collaborator

-Werror doesn't work with 2.0.20, so we either have to check the compiler version before using it, or update the Kotlin version (#213).

Closes #212

@fzhinkin fzhinkin requested review from ilya-g and woainikk March 27, 2025 20:30
@woainikk
Copy link
Contributor

Can you please also add logging for all of these flags?
For example:
freeCompilerArgs.add("-Xrender-internal-diagnostic-names")
buildScriptLogger.log(LogLevel.INFO, "-Xrender-internal-diagnostic-names enabled")
freeCompilerArgs.add("-Wextra")
buildScriptLogger.log(LogLevel.INFO, "-Wextra enabled")

@woainikk
Copy link
Contributor

woainikk commented Apr 3, 2025

And can you please also add this:
implement a Gradle property for passing additional CLI options to the Kotlin compiler
(property naming is not critical but kotlin_additional_cli_options is suggested for consistency). values are space-separated (quoting values with spaces is not supported);
e.g.: -nowarn -Xwarning-level=CONTEXT_RECEIVERS_DEPRECATED:warning
The options should go after the usual ones

@ilya-g
Copy link
Member

ilya-g commented Apr 3, 2025

-Werror doesn't work with 2.0.20

Did you mean -Wextra?
Maybe we can assume that if kotlin_Werror_override=disable is specified, the version of the compiler is also overridden to one that supports -Wextra?

@fzhinkin fzhinkin force-pushed the 212-conform-kup-requirements branch from 842013c to 216cd0a Compare April 23, 2025 13:11
build.gradle.kts Outdated
"-Wextra",
"-Xuse-fir-experimental-checkers"
)
logger.info("kotlin_Werror_override was set to 'disable'")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woainikk that'll emit a message for each and every compilation task, but I think it's better than writing it outside tasks configuration and them accidentally forgetting to setup freeCompilerArgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt new requirements imposed on Kotlin user projects
3 participants