Update LR step scheduler to use total step to work across epochs #20248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #17544
I am not sure whether to consider this as a breaking change. For
frequencies
>epoch length
I would consider it a bug fix. Forfrequencies
<epoch length
it does change the behavior but IMHO not in a fundamental way and personally I expected the new behavior to begin with.Before submitting
Was this discussed/agreed via a GitHub issue? change according to @awaelchli suggestion in Stepwise LR-Scheduler not working across epochs #17544 (comment)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes?
I don't think it is necessary, I would consider the new behavior the expected one.
Did you write any new necessary tests?
I couldn't find any tests for the old code. Q: does this need a test?
Did you verify new and existing tests pass locally with your changes? it works as expected locally
Did you list all the breaking changes introduced by this pull request? yes
Did you update the CHANGELOG? todo
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20248.org.readthedocs.build/en/20248/