Skip to content

Federated plugin refactor #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Jon-Salmon
Copy link

This pull request updates the plugin into the federated plugin architecture described here.

I am planning on adding Windows support for this plugin in the future, however, this pull request is a pre-requisite for a few reasons:

  • Windows can be implemented without platform channels, so this architecture is required to be able to implement it without adding lots of if(Platform.isWindows) to the base plugins dart files.
  • There are a few different ways in which this plugin can be implemented on Windows, each with benefits and drawbacks. This architecture would allow multiple different Windows implementations to be published to pub.dev in the future and the end-user can select an alternative one by just importing it in their projects pubspec.yaml file.

This PR doesn't have any functional changes, but does require the flutter_web_auth_platform_interface plugin to be separately published to pub.dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant