Skip to content

addressing some places where method visibilities were omitted #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/MaxCDN/OAuth/OAuthConsumer.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ class OAuthConsumer {
public $key;
public $secret;

function __construct($key, $secret, $callback_url=NULL) {
public function __construct($key, $secret, $callback_url=NULL) {
$this->key = $key;
$this->secret = $secret;
$this->callback_url = $callback_url;
}

function __toString() {
public function __toString() {
return "\\MaxCDN\\OAuth\\OAuthConsumer[key=$this->key,secret=$this->secret]";
}
}
Expand Down
10 changes: 5 additions & 5 deletions src/MaxCDN/OAuth/OAuthDataStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,23 @@
namespace MaxCDN\OAuth;

class OAuthDataStore {
function lookup_consumer($consumer_key) {
public function lookup_consumer($consumer_key) {
// implement me
}

function lookup_token($consumer, $token_type, $token) {
public function lookup_token($consumer, $token_type, $token) {
// implement me
}

function lookup_nonce($consumer, $token, $nonce, $timestamp) {
public function lookup_nonce($consumer, $token, $nonce, $timestamp) {
// implement me
}

function new_request_token($consumer, $callback = null) {
public function new_request_token($consumer, $callback = null) {
// return a new token attached to this consumer
}

function new_access_token($token, $consumer, $verifier = null) {
public function new_access_token($token, $consumer, $verifier = null) {
// return a new access token attached to this consumer
// for the user associated with this token if the request token
// is authorized
Expand Down
2 changes: 1 addition & 1 deletion src/MaxCDN/OAuth/OAuthSignatureMethod_HMAC_SHA1.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace MaxCDN\OAuth;

class OAuthSignatureMethod_HMAC_SHA1 extends OAuthSignatureMethod {
function get_name() {
public function get_name() {
return "HMAC-SHA1";
}

Expand Down
6 changes: 3 additions & 3 deletions src/MaxCDN/OAuth/OAuthToken.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class OAuthToken {
* key = the token
* secret = the token secret
*/
function __construct($key, $secret) {
public function __construct($key, $secret) {
$this->key = $key;
$this->secret = $secret;
}
Expand All @@ -22,14 +22,14 @@ function __construct($key, $secret) {
* generates the basic string serialization of a token that a server
* would respond to request_token and access_token calls with
*/
function to_string() {
protected function to_string() {
return "oauth_token=" .
OAuthUtil::urlencode_rfc3986($this->key) .
"&oauth_token_secret=" .
OAuthUtil::urlencode_rfc3986($this->secret);
}

function __toString() {
public function __toString() {
return $this->to_string();
}
}
Expand Down