Skip to content

feat(multichain-transactions-controller)!: store transactions by chain ID (support for devnet chains) #5756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 15, 2025
Merged

feat(multichain-transactions-controller)!: store transactions by chain ID (support for devnet chains) #5756

merged 19 commits into from
May 15, 2025
+222 −121

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented May 5, 2025 •
edited by ccharly
Loading

Explanation

  1. Removes the Solana mainnet filtering
  2. Reorganizes data structure to support an account[] -> chain[] -> transactions
  nonEvmTransactions: {
    [accountId: string]: {
      [chain: string]: TransactionStateEntry;
    };
  };
  1. Updates logic to reflect these changes

References

Extension PR with this package preview and working solution:

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@zone-live zone-live requested a review from a team as a code owner May 5, 2025 15:01
@zone-live zone-live changed the title chore: adds support for Solana devnet chains chore: updates support for Solana devnet chains May 5, 2025
@zone-live zone-live requested a review from a team as a code owner May 5, 2025 15:06
zone-live and others added 3 commits May 7, 2025 13:36
@zone-live @ccharly
Apply suggestions from code review
4316d74 
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
@zone-live
chore: update type
19aaf83
@zone-live
chore: lint fix
998d1d4
zone-live and others added 5 commits May 7, 2025 16:57
@zone-live @ccharly
Update packages/multichain-transactions-controller/src/MultichainTran…
a5da456 
…sactionsController.ts

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
@zone-live @ccharly
Update packages/multichain-transactions-controller/src/MultichainTran…
445b7b2 
…sactionsController.ts

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
@zone-live @ccharly
Update packages/multichain-transactions-controller/src/MultichainTran…
aa3eec7 
…sactionsController.ts

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
@zone-live
chore: lint
e1f00ff
@zone-live
Merge branch 'main' into NNT-331-allow-for-solana-devnet-txs
7bf3a3b
@zone-live zone-live requested a review from ccharly May 12, 2025 13:14
@zone-live
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "28.0.0-preview-7bf3a3b5",
  "@metamask-previews/address-book-controller": "6.0.3-preview-7bf3a3b5",
  "@metamask-previews/announcement-controller": "7.0.3-preview-7bf3a3b5",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-7bf3a3b5",
  "@metamask-previews/approval-controller": "7.1.3-preview-7bf3a3b5",
  "@metamask-previews/assets-controllers": "61.0.0-preview-7bf3a3b5",
  "@metamask-previews/base-controller": "8.0.1-preview-7bf3a3b5",
  "@metamask-previews/bridge-controller": "21.0.0-preview-7bf3a3b5",
  "@metamask-previews/bridge-status-controller": "18.0.0-preview-7bf3a3b5",
  "@metamask-previews/build-utils": "3.0.3-preview-7bf3a3b5",
  "@metamask-previews/chain-agnostic-permission": "0.6.0-preview-7bf3a3b5",
  "@metamask-previews/composable-controller": "11.0.0-preview-7bf3a3b5",
  "@metamask-previews/controller-utils": "11.8.0-preview-7bf3a3b5",
  "@metamask-previews/delegation-controller": "0.2.0-preview-7bf3a3b5",
  "@metamask-previews/earn-controller": "0.13.0-preview-7bf3a3b5",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-7bf3a3b5",
  "@metamask-previews/ens-controller": "16.0.0-preview-7bf3a3b5",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-7bf3a3b5",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-7bf3a3b5",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-7bf3a3b5",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-7bf3a3b5",
  "@metamask-previews/keyring-controller": "21.0.6-preview-7bf3a3b5",
  "@metamask-previews/logging-controller": "6.0.4-preview-7bf3a3b5",
  "@metamask-previews/message-manager": "12.0.1-preview-7bf3a3b5",
  "@metamask-previews/multichain": "4.0.0-preview-7bf3a3b5",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-7bf3a3b5",
  "@metamask-previews/multichain-network-controller": "0.6.0-preview-7bf3a3b5",
  "@metamask-previews/multichain-transactions-controller": "0.10.0-preview-7bf3a3b5",
  "@metamask-previews/name-controller": "8.0.3-preview-7bf3a3b5",
  "@metamask-previews/network-controller": "23.4.0-preview-7bf3a3b5",
  "@metamask-previews/notification-services-controller": "7.0.0-preview-7bf3a3b5",
  "@metamask-previews/permission-controller": "11.0.6-preview-7bf3a3b5",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-7bf3a3b5",
  "@metamask-previews/phishing-controller": "12.5.0-preview-7bf3a3b5",
  "@metamask-previews/polling-controller": "13.0.0-preview-7bf3a3b5",
  "@metamask-previews/preferences-controller": "17.0.0-preview-7bf3a3b5",
  "@metamask-previews/profile-sync-controller": "13.0.0-preview-7bf3a3b5",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-7bf3a3b5",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-7bf3a3b5",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-7bf3a3b5",
  "@metamask-previews/sample-controllers": "0.1.0-preview-7bf3a3b5",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-7bf3a3b5",
  "@metamask-previews/signature-controller": "28.0.0-preview-7bf3a3b5",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-7bf3a3b5",
  "@metamask-previews/transaction-controller": "55.0.0-preview-7bf3a3b5",
  "@metamask-previews/user-operation-controller": "34.0.0-preview-7bf3a3b5"
}

@zone-live zone-live mentioned this pull request May 13, 2025
Draft
7 tasks
@ccharly ccharly changed the title chore: updates support for Solana devnet chains feat(multichain-transactions-controller)!: updates support for Solana devnet chains May 15, 2025
@ccharly ccharly changed the title feat(multichain-transactions-controller)!: updates support for Solana devnet chains feat(multichain-transactions-controller)!: store transactions by chain ID (support for devnet chains) May 15, 2025
@zone-live zone-live enabled auto-merge (squash) May 15, 2025 16:13
@zone-live zone-live merged commit be5a6ff into main May 15, 2025
202 checks passed
@zone-live zone-live deleted the NNT-331-allow-for-solana-devnet-txs branch May 15, 2025 16:18
@zone-live zone-live mentioned this pull request May 16, 2025
Merged
4 tasks
Mrtenz added a commit that referenced this pull request May 16, 2025
@Mrtenz @zone-live
Release 402.0.0 (#5820)
9b02979 
## Explanation

This is the release candidate for version `402.0.0`, it includes the
following packages:
- `selected-network-controller`
- `multichain-transactions-controller`

## References

* Related to #5756

## Changelog

<!--
THIS SECTION IS NO LONGER NEEDED.

The process for updating changelogs has changed. Please consult the
"Updating changelogs" section of the Contributing doc for more.
-->

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [ ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes

---------

Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccharly ccharly ccharly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zone-live @ccharly