Skip to content

Replaced device.localcredential instances with devicelocalcredential #7119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rogersoMS
Copy link
Contributor

Based on feedback from Muchen Ji (MMD team) replaced device.localcredential instances with devicelocalcredential Also fixed a typo on the manual consent URL for multi-tenant: = should be & (same as single tenant ID essentially)

Based on feedback from Muchen Ji (MMD team) replaced device.localcredential instances with devicelocalcredential
Also fixed a typo on the manual consent URL for multi-tenant: <YourClientAppID>= should be <YourClientAppID>& (same as single tenant ID essentially)
@prmerger-automator
Copy link
Contributor

@rogersoMS : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 246dc4d:

✅ Validation status: passed

File Status Preview URL Details
WindowsServerDocs/identity/laps/laps-scenarios-azure-active-directory.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Mar 23, 2023

@robinharwood, @Xelu86

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Mar 23, 2023
@Court72 Court72 requested review from robinharwood and Xelu86 March 23, 2023 14:43
@jay98014
Copy link
Contributor

I reviewed this. The changes look fine from a technical perspective. Thanks - Jay

@jay98014
Copy link
Contributor

#sign-off

@jay98014
Copy link
Contributor

#sign-off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants