-
Notifications
You must be signed in to change notification settings - Fork 16
Creation of Offline Installation topic. #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Creation of Offline Installation topic. #350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Kory! Great start! Thank you for the quick action on this. In general looks good with some comments.
Replace 'repository' with 'registry'. Co-authored-by: Dmitry Shishlyannikov <9266670+byDimasik@users.noreply.github.com>
Spacing fix. Co-authored-by: Dmitry Shishlyannikov <9266670+byDimasik@users.noreply.github.com>
Add a link to skopeo reference. Co-authored-by: Dmitry Shishlyannikov <9266670+byDimasik@users.noreply.github.com>
Change wget command to curl command. Co-authored-by: Dmitry Shishlyannikov <9266670+byDimasik@users.noreply.github.com>
Spacing fix. Co-authored-by: Dmitry Shishlyannikov <9266670+byDimasik@users.noreply.github.com>
Remove line inadvertently left in following edit. Co-authored-by: Dmitry Shishlyannikov <9266670+byDimasik@users.noreply.github.com>
Add 'a' to mke.yaml reference. Co-authored-by: Dmitry Shishlyannikov <dshishliannikov@mirantis.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there; just a few last comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here are the last two and we are good. I'm approving this PR now to speed up the process, but I assume you will still address the last two comments. Thank you for the quick and hard work!
Transition to provided flag names. Co-authored-by: Dmitry Shishlyannikov <dshishliannikov@mirantis.com>
Strip out vagueish 'artifacts' in favor of 'images and charts'. Co-authored-by: Dmitry Shishlyannikov <dshishliannikov@mirantis.com>
Hyphenate 'repull'. Co-authored-by: Magdalena Dziadosz <160592158+MagdaDziadosz@users.noreply.github.com>
Remove extraneous ', though,'. Co-authored-by: Magdalena Dziadosz <160592158+MagdaDziadosz@users.noreply.github.com>
Co-authored-by: Magdalena Dziadosz <160592158+MagdaDziadosz@users.noreply.github.com>
No description provided.