Skip to content

Creation of Offline Installation topic. #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

KoryKessel-Mirantis
Copy link
Collaborator

No description provided.

@KoryKessel-Mirantis KoryKessel-Mirantis added the Docs-A Must Do label Apr 23, 2025
@KoryKessel-Mirantis KoryKessel-Mirantis added this to the 4.1.0 milestone Apr 23, 2025
@KoryKessel-Mirantis KoryKessel-Mirantis self-assigned this Apr 23, 2025
@KoryKessel-Mirantis KoryKessel-Mirantis requested a review from a team as a code owner April 23, 2025 16:08
Copy link
Collaborator

@byDimasik byDimasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Kory! Great start! Thank you for the quick action on this. In general looks good with some comments.

KoryKessel-Mirantis and others added 7 commits April 24, 2025 16:37
Replace 'repository' with 'registry'.

Co-authored-by: Dmitry Shishlyannikov <9266670+byDimasik@users.noreply.github.com>
Spacing fix.

Co-authored-by: Dmitry Shishlyannikov <9266670+byDimasik@users.noreply.github.com>
Add a link to skopeo reference.

Co-authored-by: Dmitry Shishlyannikov <9266670+byDimasik@users.noreply.github.com>
Change wget command to curl command.

Co-authored-by: Dmitry Shishlyannikov <9266670+byDimasik@users.noreply.github.com>
Spacing fix.

Co-authored-by: Dmitry Shishlyannikov <9266670+byDimasik@users.noreply.github.com>
Remove line inadvertently left in following edit.

Co-authored-by: Dmitry Shishlyannikov <9266670+byDimasik@users.noreply.github.com>
Add 'a' to mke.yaml reference.

Co-authored-by: Dmitry Shishlyannikov <dshishliannikov@mirantis.com>
@byDimasik byDimasik linked an issue Apr 24, 2025 that may be closed by this pull request
Copy link
Collaborator

@byDimasik byDimasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there; just a few last comments

Copy link
Collaborator

@byDimasik byDimasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here are the last two and we are good. I'm approving this PR now to speed up the process, but I assume you will still address the last two comments. Thank you for the quick and hard work!

KoryKessel-Mirantis and others added 2 commits April 25, 2025 00:42
Transition to provided flag names.

Co-authored-by: Dmitry Shishlyannikov <dshishliannikov@mirantis.com>
Strip out vagueish 'artifacts' in favor of 'images and charts'.

Co-authored-by: Dmitry Shishlyannikov <dshishliannikov@mirantis.com>
KoryKessel-Mirantis and others added 3 commits April 29, 2025 10:43
Hyphenate 'repull'.

Co-authored-by: Magdalena Dziadosz <160592158+MagdaDziadosz@users.noreply.github.com>
Remove extraneous ', though,'.

Co-authored-by: Magdalena Dziadosz <160592158+MagdaDziadosz@users.noreply.github.com>
Co-authored-by: Magdalena Dziadosz <160592158+MagdaDziadosz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs-A Must Do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airgap docs (Offline Installation and upgrade from MKE 3)
3 participants