Skip to content

add new variable for extra configuratuon in elasticsearch.yml #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 16, 2024
Merged

add new variable for extra configuratuon in elasticsearch.yml #299

merged 4 commits into from
Jan 16, 2024

Conversation

xtruthx
Copy link
Member

@xtruthx xtruthx commented Jan 16, 2024

Close #298

@xtruthx xtruthx requested a review from widhalmt January 16, 2024 07:52
widhalmt
widhalmt previously requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@widhalmt widhalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for the addition. This will actually be very helpful.

I have an annotation where I'm not sure if I found something or not. Please let me know and I'll "Approve".

Cheers,
Thomas

@widhalmt
Copy link
Member

If you're wondering, why the required checks aren't running -> #300 . I'm fixing this right now.

@xtruthx
Copy link
Member Author

xtruthx commented Jan 16, 2024

If you're wondering, why the required checks aren't running -> #300 . I'm fixing this right now.

great i need it today...

@widhalmt
Copy link
Member

Just a few moments...

@tbauriedel
Copy link
Member

tbauriedel commented Jan 16, 2024 •
edited
Loading

@xtruthx
The necessary changes are now implemented in main (at the moment still in the merge queue).
You must merge them in your branch so that the pipelines can start.

@tbauriedel tbauriedel self-requested a review January 16, 2024 14:30
widhalmt
widhalmt reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@widhalmt widhalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I requested a second opinion because recent times had me a bit confused. I don't want to miss something important. But of couse, I undo the "request changes". Should be done very soon.

@widhalmt widhalmt dismissed their stale review January 16, 2024 14:34

Arranged for another reviewer

@widhalmt widhalmt enabled auto-merge January 16, 2024 14:34
@widhalmt widhalmt added the feature New feature or request label Jan 16, 2024
@widhalmt widhalmt added this to the 1.0.0 milestone Jan 16, 2024
tbauriedel
tbauriedel requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@tbauriedel tbauriedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found only a small typo.
The rest looks good

@xtruthx @tbauriedel
Update docs/role-elasticsearch.md
792ae4b 
Co-authored-by: Tobias Bauriedel <tobias@bauriedel.de>
@widhalmt widhalmt added this pull request to the merge queue Jan 16, 2024
Merged via the queue into NETWAYS:main with commit 5a91f3b Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@widhalmt widhalmt widhalmt left review comments

@tbauriedel tbauriedel tbauriedel approved these changes

Assignees

@xtruthx xtruthx

Labels
feature New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

[Feature] Adding variable "elasticsearch_extra_config"
3 participants
@xtruthx @widhalmt @tbauriedel