Skip to content

Remove actions for pushs #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Remove actions for pushs #303

merged 3 commits into from
Jan 16, 2024

Conversation

tbauriedel
Copy link
Member

@tbauriedel tbauriedel commented Jan 16, 2024

At the moment workflows are triggered for PRs and pushs.

The workflow to contribute says that a PR must be created beforehand for each contribution into main.
For this reason (and to avoid duplicate workflows), github workflows should only be triggered for PRs.

I have also checked this branch before creating the PR. No workflow were scheduled.

Fixes #302

@tbauriedel tbauriedel added the bug Something isn't working label Jan 16, 2024
@tbauriedel tbauriedel added this to the 1.0.0 milestone Jan 16, 2024
@tbauriedel tbauriedel requested a review from widhalmt January 16, 2024 15:48
@widhalmt widhalmt enabled auto-merge January 16, 2024 15:48
@widhalmt
Copy link
Member

Looks good. I'll let pipelines run and check if everything works as expected. Maybe, when all succeeded we can do another push and try of they still work? The both of us are quite sure that it will work but this might still help with finding unexpected behaviour.

@tbauriedel
Copy link
Member Author

I have also enabled that the linter will run always.

@tbauriedel
Copy link
Member Author

Looks good. I'll let pipelines run and check if everything works as expected. Maybe, when all succeeded we can do another push and try of they still work? The both of us are quite sure that it will work but this might still help with finding unexpected behaviour.

Sure. You can start one after that.
If something is missing, I can check that again.

@widhalmt
Copy link
Member

When everything's done, I'll just update the branch from main. We should then see if they run again. If they do, I'll approve. This should speed up checks again (by a lot)

@tbauriedel
Copy link
Member Author

Works ;)

Copy link
Member

@widhalmt widhalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipelines work as expected, now. Thanks!

@widhalmt widhalmt added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit 0305dfa Jan 16, 2024
@widhalmt widhalmt deleted the fix/duplicate-workflows-302 branch January 16, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Workflows triggered more than once
2 participants