Skip to content

Fix apt key handling2 #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zerwes
Copy link
Contributor

@zerwes zerwes commented Jan 27, 2024

f/u to #306
Refactored key and sources list for debian based distros. Use current state of the art to include 3party repos.

  • avoid apt warning
    W:https://artifacts.elastic.co/packages/8.x/apt/dists/stable/InRelease: Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for details
  • prepare for deb822 format:
    • Entries MUST be added in the /etc/apt/sources.list.d directory using a shortened repository name

    • A sources.list entry SHOULD have the signed-by option set.

see: https://wiki.debian.org/DebianRepository/UseThirdParty

PS: this time I have run the checks in question (sorry for my carelessness in the other PR):

@widhalmt widhalmt self-requested a review January 29, 2024 08:41
@widhalmt widhalmt added the bug Something isn't working label Jan 29, 2024
@widhalmt widhalmt added this to the 1.0.0 milestone Jan 29, 2024
@widhalmt widhalmt enabled auto-merge February 9, 2024 17:53
Copy link
Member

@widhalmt widhalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked in my tests. Thank you so much for your contribution!

@widhalmt widhalmt added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@widhalmt widhalmt added this pull request to the merge queue Feb 11, 2024
Merged via the queue into NETWAYS:main with commit 67e4c24 Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants