Skip to content

Ensure fetch_ctk action can be used everywhere #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
May 4, 2025
Merged

Conversation

leofang
Copy link
Member

@leofang leofang commented May 2, 2025

Description

closes #599
closes #588

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofang leofang self-assigned this May 2, 2025
Copy link
Contributor

copy-pr-bot bot commented May 2, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test ccb6967

@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test 562b558

@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test 270b681

@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test 9e665db

@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test 38830b2

@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test 2bb32a9

@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test dc633dc

@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test cd69de3

@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test 52adef2

@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test d5c7be2

1 similar comment
@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test d5c7be2

@leofang leofang closed this May 2, 2025
@leofang leofang reopened this May 2, 2025
@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test d5c7be2

1 similar comment
@leofang
Copy link
Member Author

leofang commented May 2, 2025

/ok to test d5c7be2

This comment has been minimized.

@leofang
Copy link
Member Author

leofang commented May 3, 2025

/ok to test 1b02e55

@leofang
Copy link
Member Author

leofang commented May 3, 2025

/ok to test 7a0e053

@leofang
Copy link
Member Author

leofang commented May 3, 2025

/ok to test 96ecae0

@leofang
Copy link
Member Author

leofang commented May 3, 2025

/ok to test a73564c

@leofang
Copy link
Member Author

leofang commented May 4, 2025

/ok to test 78d0113

@leofang
Copy link
Member Author

leofang commented May 4, 2025

/ok to test 390995a

@leofang
Copy link
Member Author

leofang commented May 4, 2025

/ok to test 65e19b2

@leofang
Copy link
Member Author

leofang commented May 4, 2025

/ok to test 6ade91b

@leofang leofang closed this May 4, 2025
auto-merge was automatically disabled May 4, 2025 02:55

Pull request was closed

@leofang
Copy link
Member Author

leofang commented May 4, 2025

/ok to test 6ade91b

@leofang leofang reopened this May 4, 2025
@leofang leofang enabled auto-merge (squash) May 4, 2025 03:27
@leofang
Copy link
Member Author

leofang commented May 4, 2025

OK @rwgk this PR is ready/safe to merge. I confirm fetch_ctk can handle all cache hit/miss paths properly on all supported GHA runners:

@leofang leofang merged commit 9579678 into NVIDIA:main May 4, 2025
150 checks passed
@leofang leofang deleted the fix_win branch May 4, 2025 03:51
Copy link

github-actions bot commented May 4, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD infrastructure enhancement Any code-related improvements P0 High priority - Must do!
Projects
None yet
2 participants