Skip to content

Parse numbers as strings #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Parse numbers as strings #293

merged 1 commit into from
Apr 15, 2025

Conversation

piegamesde
Copy link
Member

We have no business in caring about what semantics Nix happens to ascribe to these numbers. For all we care about, they are opaque strings of digits.

Fixes #292

We have no business in caring about what semantics Nix happens to
ascribe to these numbers. For all we care about, they are opaque strings
of digits.

Fixes NixOS#292
Copy link

github-actions bot commented Apr 13, 2025

Nixpkgs diff

Copy link

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review the haskell, but I approve of the concept.

@jfly jfly merged commit 2c611ac into NixOS:master Apr 15, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Nix formatting Apr 15, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/formatting-team-meeting-2025-04-15/63097/1

@infinisil infinisil deleted the numbers branch April 15, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Out of bounds numbers get rewritten
5 participants