Skip to content

Set admin active menu based on ADMIN_RESOURCE #4707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Set admin active menu based on ADMIN_RESOURCE #4707

wants to merge 7 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Mar 15, 2025 •
edited
Loading

Admin active menu is related to an ACL resource ...

Instead of manually set (eg)

->_setActiveMenu('sales/creditmemo') yopu can use ->_setActiveMenu(self::ADMIN_RESOURCE) in most cases.

@sreichel
set menu (wip)
41c6063
@sreichel
Merge branch 'main' into set-active-menu
f14d360
@sreichel
Merge branch 'main' into set-active-menu
0705ccd 
# Conflicts:
#	app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php
@sreichel sreichel changed the title Set admin active menu based onADMIN_RESOURCE Set admin active menu based on ADMIN_RESOURCE Mar 15, 2025
@github-actions github-actions bot added Component: lib/Varien Relates to lib/Varien Component: Adminhtml Relates to Mage_Adminhtml Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Widget Relates to Mage_Widget Component: Oauth Relates to Mage_Oauth Component: Index Relates to Mage_Index Component: ImportExport Relates to Mage_ImportExport Component: lib/* Relates to lib/* labels Mar 15, 2025
@sreichel sreichel marked this pull request as ready for review March 15, 2025 23:49
@sreichel sreichel marked this pull request as draft March 16, 2025 13:06
@sreichel sreichel marked this pull request as ready for review March 31, 2025 01:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
20.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sreichel sreichel closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Oauth Relates to Mage_Oauth Component: Widget Relates to Mage_Widget enhancement phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sreichel