Skip to content

Shorter copyright header #4767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Shorter copyright header #4767

wants to merge 13 commits into from

Conversation

sreichel
Copy link
Contributor

Related Pull Requests

@github-actions github-actions bot added environment Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: AdminNotification Relates to Mage_AdminNotification Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: Adminhtml Relates to Mage_Adminhtml Mage.php Relates to app/Mage.php Component: Api PageRelates to Mage_Api Component: Cron Relates to Mage_Cron Component: Captcha Relates to Mage_Captcha Component: Contacts Relates to Mage_Contacts Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: CatalogRule Relates to Mage_CatalogRule Component: Admin Relates to Mage_Admin Component: Downloadable Relates to Mage_Downloadable Component: Bundle Relates to Mage_Bundle labels Apr 21, 2025
@github-actions github-actions bot added Component: CatalogIndex Relates to Mage_CatalogIndex Component: Api2 Relates to Mage_Api2 Component: Directory Relates to Mage_Directory Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: CatalogSearch Relates to Mage_CatalogSearch Component: Authorizenet Relates to Mage_Authorizenet Component: Centinel Relates to Mage_Centinel Component: Dataflow Relates to Mage_Dataflow labels Apr 21, 2025
sreichel added a commit to sreichel/magento-lts that referenced this pull request Apr 21, 2025
@sreichel
Copy link
Contributor Author

@sreichel sreichel marked this pull request as draft April 21, 2025 16:33
@sreichel sreichel marked this pull request as ready for review April 21, 2025 17:43
@github-actions github-actions bot removed the Component: Eav Relates to Mage_Eav label Apr 21, 2025
@sreichel
Copy link
Contributor Author

This PR saves +370 bytes per copyright header. For +5k files.

Thats 1850000 bytes in total ... minimum.

According to https://ecoping.earth/tools/convert-bytes-to-co2-grams/

0.65 gCO2e - every time your resource is loaded.

@kiatng
Copy link
Contributor

kiatng commented Apr 23, 2025

If a developer or third party extracts a single source file without also copying the COPYING.txt file, they might not see the copyright information. The risk lies in potential misattribution if files become separated from the central notice.

@sreichel
Copy link
Contributor Author

sreichel commented Apr 23, 2025

... months later 👍

@kiatng after all that commits and discussions ... now when its finished ... its no good?

(macht Spass^^)

@sreichel sreichel closed this Apr 23, 2025
@addison74
Copy link
Contributor

My opinion is that when a developer extracts a file from the OM package, he should be careful about copyright. It is not my responsibility to check whether he respects copyright or not.

@sreichl - please don't close any PR's without waiting for other opinions.

@sreichel
Copy link
Contributor Author

sreichel commented Apr 23, 2025

please don't close any PR's without waiting for other opinions.

Started Jan, 9th ... after multiple changes, AI try, now again manual changes via regex replace ... take it or leave it.

I try my best, but when its not enough - its not enough. Case closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: AdminNotification Relates to Mage_AdminNotification Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Contacts Relates to Mage_Contacts Component: Core Relates to Mage_Core Component: Cron Relates to Mage_Cron Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable environment Mage.php Relates to app/Mage.php
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants