feat(app): Flex Stacker module card statuses #18058
Open
+176
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahiuchingau
requested review from
mjhuff and
smb2268
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18058 +/- ##
==========================================
- Coverage 25.59% 23.94% -1.66%
==========================================
Files 2995 3008 +13
Lines 232829 235149 +2320
Branches 20089 20129 +40
==========================================
- Hits 59596 56296 -3300
- Misses 173218 178841 +5623
+ Partials 15 12 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
smb2268
reviewed
Apr 14, 2025
smb2268
reviewed
Apr 14, 2025
smb2268
reviewed
Apr 14, 2025
smb2268
reviewed
Apr 15, 2025
| status: 'Idle', | ||
| const shuttleDisplayStatus = i18n.format( | ||
| moduleData.platformState === 'extended' | ||
| ? t('flex_stacker_extended') |
There was a problem hiding this comment.
We try not to do nested ternaries since they can be tricky to read and it's easy for bugs to arise. Can you refactor this to an if/else chain or maybe create a map of [platformState]: i18n key for this?
smb2268
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the labware shuttle status for the Flex Stacker in the app module card, and updates the rendering of the door status as well to match that in the design.