Skip to content

chore: new names for evo labware #18079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025
Merged

chore: new names for evo labware #18079

merged 5 commits into from
Apr 16, 2025

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Apr 15, 2025

Remove the external branding from our resin tips labware. The new names follow the format ev_resin_tips_....

Update the

  • definitions
    • including stacking overlaps
  • blocklists
  • test fixtures
  • image bindings in lablib
  • image bindings in app labware tab

screenshots

lablib

top-lablib
tall-lablib
short-lablib
tall-with-tiprack-lablib

app

top-app-slideout
tall-tiprack-app-slideout
tall-app-slideout
short-app-slideout
top-app-summary
tall-tiprack-app-summary
tall-app-summary
short-app-summary

simulation

Simulates ok with the ABR protocol after fixes (change the names, remove the soak plate)

review

  • did i miss any bits

@sfoster1 sfoster1 requested a review from jerader April 15, 2025 18:08
@sfoster1 sfoster1 requested review from a team as code owners April 15, 2025 18:08
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 27.26%. Comparing base (5c731d4) to head (7844663).
Report is 3 commits behind head on chore_release-8.4.0.

Files with missing lines Patch % Lines
...ibrary/src/components/labware-ui/labware-images.ts 0.00% 7 Missing ⚠️
...s/Desktop/Labware/LabwareDetails/labware-images.ts 0.00% 2 Missing ⚠️
...src/local-resources/labware/hooks/useAllLabware.ts 0.00% 1 Missing ⚠️
...p/src/organisms/ODD/QuickTransferFlow/constants.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-8.4.0   #18079   +/-   ##
====================================================
  Coverage                27.26%   27.26%           
====================================================
  Files                     3111     3111           
  Lines                   236181   236178    -3     
  Branches                 19886    19886           
====================================================
  Hits                     64398    64398           
+ Misses                  171767   171764    -3     
  Partials                    16       16           
Flag Coverage Δ
protocol-designer 18.75% <26.66%> (+<0.01%) ⬆️
step-generation 4.34% <26.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
shared-data/js/getLabware.ts 70.53% <100.00%> (ø)
...src/local-resources/labware/hooks/useAllLabware.ts 0.00% <0.00%> (ø)
...p/src/organisms/ODD/QuickTransferFlow/constants.ts 0.00% <0.00%> (ø)
...s/Desktop/Labware/LabwareDetails/labware-images.ts 0.00% <0.00%> (ø)
...ibrary/src/components/labware-ui/labware-images.ts 0.20% <0.00%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -3,14 +3,7 @@ import { getValidCustomLabware } from '/app/redux/custom-labware'
import { getAllDefinitions } from '../utils'
import type { LabwareSort, LabwareFilter, LabwareDefAndDate } from '../types'

// labware to filter out from the labware tab of the desktop app
// TODO (sb:1/14/25) remove evotips from blocklist before public launch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof lol good catch

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you!

sfoster1 added a commit that referenced this pull request Apr 15, 2025
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Does "EV" stand for anything, or is it just a workaround abbreviation of "Evotip"?

@sfoster1 sfoster1 merged commit dd82c32 into chore_release-8.4.0 Apr 16, 2025
78 of 79 checks passed
@sfoster1 sfoster1 deleted the evotips-rename branch April 16, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants