Skip to content

refactor(api): height from volume binary search draft #18081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: edge
Choose a base branch
from

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Apr 15, 2025

Overview

Trying to make tubes not take 2 minutes to use meniscus-relative pipetting with

Review Requests

Initially I tried to do this recursively and lint yelled at me does anybody know why?

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.17%. Comparing base (6c48867) to head (04cfb5e).
Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #18081       +/-   ##
===========================================
+ Coverage   25.55%   62.17%   +36.62%     
===========================================
  Files        2996     2997        +1     
  Lines      233046   233247      +201     
  Branches    20100    20374      +274     
===========================================
+ Hits        59548   145016    +85468     
+ Misses     173483    88051    -85432     
- Partials       15      180      +165     
Flag Coverage Δ
protocol-designer 18.77% <ø> (ø)
step-generation 4.40% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pentrons_shared_data/labware/labware_definition.py 80.22% <ø> (ø)

... and 1627 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant