Skip to content

feat(api): remove incompatible consolidate & distribute tip options, fix distribute blowout bug #18082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanni-t
Copy link
Member

@sanni-t sanni-t commented Apr 15, 2025

Closes AUTH-1734

Overview

  • Updates distribute_with_liquid_class() and consolidate_with_liquid_class to raise an error if new_tip is "always" or "per source"
  • Also fixes a bug where blowout volumes during distribution were not being tracked correctly internally

Test Plan and Hands on Testing

Added integration and unit tests. Those should be sufficient since these errors will be caught early in analysis.

Review requests

  • anything I missed?

Risk assessment

Low

@sanni-t sanni-t requested a review from a team as a code owner April 15, 2025 20:15
@sanni-t sanni-t requested a review from jbleon95 April 15, 2025 20:15
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.26%. Comparing base (a38937c) to head (1802e2f).
Report is 8 commits behind head on chore_release-8.4.0.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-8.4.0   #18082   +/-   ##
====================================================
  Coverage                27.26%   27.26%           
====================================================
  Files                     3111     3111           
  Lines                   236181   236181           
  Branches                 19886    19886           
====================================================
  Hits                     64398    64398           
  Misses                  171767   171767           
  Partials                    16       16           
Flag Coverage Δ
protocol-designer 18.75% <ø> (ø)
step-generation 4.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jbleon95 jbleon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the choice to limit consolidate and distribute, all looks good here

@sanni-t sanni-t merged commit 9bb4f3e into chore_release-8.4.0 Apr 16, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants