feat: Add time_zone to Datetime results
#33
Conversation
allows setting a time zone for datetimes and checking if the values in the column matches it
dfrankland
requested review from
borchero,
AndreasAlbertQC and
delsner
as code owners
dfrankland
changed the title
time_zone to Datetime resultstime_zone to Datetime results
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 1845 1850 +5
=========================================
+ Hits 1845 1850 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thanks for the nice PR @dfrankland! Could you add a test in test_sql_schema.py for the oracle part?
There was a problem hiding this comment.
Thanks for the initiative @dfrankland, I think this is a very useful addition! :)
borchero
changed the title
time_zone to Datetime resultstime_zone to Datetime results
|
Let me know if you'd like for me to rebase these changes |
dfrankland
force-pushed
the
add-time_zone-to-datetime-results
branch
from
8de8c8f to
30e3538
Compare
|
Updated to keep things minimal and also made the test name more accurate |
| return pa.timestamp("us") | ||
| time_zone = ( | ||
| self.time_zone.tzname(None) | ||
| if isinstance(self.time_zone, dt.timezone) |
There was a problem hiding this comment.
Doesn't this mirror the type annotation? 😄
| if isinstance(self.time_zone, dt.timezone) | |
| if isinstance(self.time_zone, dt.tzinfo) |
| from dataframely._compat import ( | ||
| pa, | ||
| sa, | ||
| sa_mssql, | ||
| sa_TypeEngine, | ||
| ) |
There was a problem hiding this comment.
Nothing changed here, right?
| from dataframely._compat import ( | |
| pa, | |
| sa, | |
| sa_mssql, | |
| sa_TypeEngine, | |
| ) | |
| from dataframely._compat import pa, sa, sa_mssql, sa_TypeEngine |
Motivation
Closes #32
Changes
allows setting a time zone for datetimes and checking if the values in the column matches it
Pertinent polars docs:
https://docs.pola.rs/user-guide/transformations/time-series/timezones/