Skip to content

Create documentation template using mdbook #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

zephaniahong
Copy link

@zephaniahong zephaniahong commented Aug 21, 2022

Created a general template for future API documentation, tutorials, etc...

@zephaniahong zephaniahong linked an issue Aug 21, 2022 that may be closed by this pull request
@zephaniahong zephaniahong marked this pull request as ready for review August 21, 2022 10:31
@zephaniahong zephaniahong requested a review from John15321 August 21, 2022 10:31
@John15321
Copy link
Contributor

I have an important thing at work tomorrow and a few job interviews on Tue. So I'm probably gonna check this out on Wed, sorry for delay. Also you can add a GitHub actions ci job in the same PR if you want

@zephaniahong
Copy link
Author

No worries! All the best(:
Could I clarify what the CI job would/should do?
Are you referring to something like this: https://github.com/marketplace/actions/mdbook-action#getting-started?

@John15321
Copy link
Contributor

No worries! All the best(:
Could I clarify what the CI job would/should do?
Are you referring to something like this: https://github.com/marketplace/actions/mdbook-action#getting-started?

I'm talking about creating a GitHub Actions CI job that triggers when someone pushes to develop and hosts the mdbook using GitHub io

@zephaniahong zephaniahong removed the request for review from John15321 August 22, 2022 12:40
@zephaniahong zephaniahong marked this pull request as draft August 22, 2022 12:41
@zephaniahong zephaniahong self-assigned this Aug 22, 2022
@dawnofmidnight
Copy link

dawnofmidnight commented Sep 4, 2022

Quick suggestion: you should probably add guide/book to the gitignore, since you don't want to push all the built artifacts to version control every time.

@zephaniahong
Copy link
Author

zephaniahong commented Sep 5, 2022

Quick suggestion: you should probably add guide/book to the gitignore, since you don't want to push all the built artifacts to version control every time.

Hey @dawnofmidnight! Correct me if I'm wrong but won't that mean no one else would have a copy of the book?

@dawnofmidnight
Copy link

dawnofmidnight commented Sep 5, 2022

Quick suggestion: you should probably add guide/book to the gitignore, since you don't want to push all the built artifacts to version control every time.

Hey @dawnofmidnight! Correct me if I'm wrong but won't that mean no one else would have a copy of the book?

The typical workflow for mdbook is for your to only commit the source (markdown) files to git. People should build their own html version locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create project documentation in markdown using mdbook
3 participants