Skip to content

feat: implement new callback semantics #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
May 13, 2025
Merged

feat: implement new callback semantics #3614

merged 25 commits into from
May 13, 2025

Conversation

AayushSabharwal
Copy link
Member

Cleanup of #3452 and #3613 which avoids rebase issues and merge conflicts

vyudu and others added 22 commits May 9, 2025 15:07
Co-authored-by: vyudu <vincent.duyuan@gmail.com>
Co-authored-by: vyudu <vincent.duyuan@gmail.com>
Co-authored-by: vyudu <vincent.duyuan@gmail.com>
…itions

Co-authored-by: vyudu <vincent.duyuan@gmail.com>
Co-authored-by: vyudu <vincent.duyuan@gmail.com>
Co-authored-by: vyudu <vincent.duyuan@gmail.com>
Co-authored-by: vyudu <vincent.duyuan@gmail.com>
@AayushSabharwal
Copy link
Member Author

This is good to go. InterfaceII failures are broken BVDiffEq tests now passing. FMI failure is weird - the ME SymbolicDiscreteCallback has a condition that is always true. It triggers at every solver step. The affect function changes nothing. Yet, it fails CheckInit.

@AayushSabharwal AayushSabharwal merged commit 22b5a69 into v10 May 13, 2025
23 of 45 checks passed
@AayushSabharwal AayushSabharwal deleted the cbtest-new branch May 13, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants