Fix StackOverflow in variable parsing #7809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
sovdeeth
requested review from
UnderscoreTud and
Pesekjak
and removed request for
a team
sovdeeth
force-pushed
the
patch/fix-overflow-in-csv-parsing
branch
from
bcd6538 to
ce19947
Compare
Burbulinis
approved these changes
Apr 19, 2025
sovdeeth
changed the title
…ter docs sorry no 1 character pr today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CSV parsing regex is extraordinarily slow at matching quoted variable names, to the point it causes StackOverflows that prevent variables from being loaded at all. This is due to the regex matching checking for "", then matching "" or a single character, and repeat for the next character, until it recurses too far. This PR fixes that by allowing the matching of multiple non-" characters between each "" check.
Target Minecraft Versions: any
Requirements: none
Related Issues: none