Skip to content

Update ExprSecCreateWorldBorder #7827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: dev/patch
Choose a base branch
from
Open

Update ExprSecCreateWorldBorder #7827

wants to merge 3 commits into from

Conversation

Absolutionism
Copy link
Contributor

Description

This PR fixes ExprSecCreateWorldBorder by changing the creation of the WorldBorder from init to get.
Allowing new WorldBorders for each time the same instance calls get. (i.e. inside functions and loops)

Target Minecraft Versions: any
Requirements: none
Related Issues: #7825

@Absolutionism Absolutionism requested a review from a team as a code owner April 24, 2025 21:10
@Absolutionism Absolutionism requested review from Pikachu920 and erenkarakal and removed request for a team April 24, 2025 21:10
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Apr 24, 2025
Fusezion
Fusezion approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this also be move outside of the expressions package and into sections? I don't see why this would be an expressions when effect sections are in section package as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Efnilite Efnilite Efnilite approved these changes

@Fusezion Fusezion Fusezion approved these changes

@Pikachu920 Pikachu920 Awaiting requested review from Pikachu920 Pikachu920 is a code owner automatically assigned from SkriptLang/core-developers

@erenkarakal erenkarakal Awaiting requested review from erenkarakal erenkarakal is a code owner automatically assigned from SkriptLang/core-developers

Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Absolutionism @sovdeeth @Efnilite @Fusezion