✨ Define SemanticSegmentor with the New EngineABC
#866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-define-engines-abc #866 +/- ##
==========================================================
+ Coverage 91.52% 91.58% +0.06%
==========================================================
Files 73 74 +1
Lines 9061 9143 +82
Branches 1188 1201 +13
==========================================================
+ Hits 8293 8374 +81
Misses 756 756
- Partials 12 13 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
- Use `input_resolutions` instead of resolution to make engines outputs compatible with ioconfig. - Uses input resolution as a list of dictionaries on units and resolution.
- Use `input_resolutions` instead of resolution to make engines outputs compatible with ioconfig. - Uses input resolution as a list of dictionaries on units and resolution.
…mentor # Conflicts: # tests/engines/test_engine_abc.py # tests/engines/test_patch_predictor.py # tiatoolbox/models/engine/engine_abc.py # tiatoolbox/models/engine/io_config.py # tiatoolbox/models/engine/patch_predictor.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…nto dev-define-semantic-segmentor
| ) | ||
| for layer_ in contours: | ||
| coords = layer_.squeeze() | ||
| count += 1 |
There was a problem hiding this comment.
I believe this method treats all contours as outer contours, including those that are actually holes. So it may accidentally draw holes as normal filled polygons unless further post-processing is added to distinguish parent and child contours.
There was a problem hiding this comment.
This will especially be a problem for semantic segmentation.
| patch_output: dict | zarr.group, | ||
| scale_factor: tuple[float, float], | ||
| class_dict: dict | None = None, | ||
| save_path: Path | None = None, | ||
| ) -> AnnotationStore | Path: | ||
| """Converts (and optionally saves) output of TIAToolbox engines as AnnotationStore. | ||
| """Converts output of TIAToolbox PatchPredictor engines to AnnotationStore. |
|
|
||
| Args: | ||
| images (list, ndarray): | ||
| List of inputs to process. when using `patch` mode, the |
| @@ -572,6 +573,10 @@ class PatchDataset(PatchDatasetABC): | |||
| labels (list): | |||
| List of labels for sample at the same index in `inputs`. | |||
| Default is `None`. | |||
| patch_input_shape (tuple): | |||
| Size of patches input to the model. Patches are at | |||
There was a problem hiding this comment.
Can the text be pushed one tab back to line up with labels?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SemanticSegmentorwith the NewEngineABC