-
Notifications
You must be signed in to change notification settings - Fork 292
Replace nightly version with trunk #2185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Replace nightly version with trunk #2185
Conversation
Thanks for contributing to Playground @karthick-murugan 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good?
Thanks, @bgrgicak! My goal with replacing the nightly version with trunk is to streamline the Playground experience by:
|
Thanks for the context @karthick-murugan this helps a lot. What's the difference between pulling from Have you considered only adding Unrelated to the @adamziel I would love your feedback on this PR and some guidance for the direction we should take. |
Yes @bgrgicak updated the description as such.
Nightly builds were committed daily via a GitHub Action, leading to significant repository bloat over time. Trunk is downloaded dynamically from GitHub (https://github.com/WordPress/WordPress/archive/refs/heads/trunk.zip), so there are no additional commits, keeping the Playground repo lightweight.
Nightly builds were committed daily via a GitHub Action, leading to significant repository bloat over time. Trunk is downloaded dynamically from GitHub (https://github.com/WordPress/WordPress/archive/refs/heads/trunk.zip), so there are no additional commits, keeping the Playground repo lightweight.
Yes will update the relevant docs and other places. Let me know if you'd like those doc changes as part of this PR or in a separate one. |
Sorry my question wasn't clear. How frequently does WordPress create Nightly builds? Is Nightly equivalent to the latest If not is there a Also, we need to keep in mind that Playground bundles WordPress to optimize it for the browser, if we stop creating a |
Thanks for the follow-up, @bgrgicak!
Yes, WordPress Nightly builds are created daily and are effectively snapshots of the latest trunk branch. So functionally, Nightly is equivalent to the current state of trunk, just packaged and committed each day as a .zip.
No, WordPress doesn't maintain a separate nightly branch. The Nightly zip is generated from trunk, so we’re essentially duplicating what’s already available directly via GitHub.
Good Point. Need some feedbacks regarding this and some insights to move forward in the correct way. |
Me too. 😅 I'm curious what @adamziel thinks. I will try to summarize my list of open questions:
Thanks for your work so far @karthick-murugan I appreciate the discussion. |
I’m all for removing the daily CI rebuilds. They inflate the repository size so much. I’m mostly concerned about the download size of the major releases. A larger download size for nightly/trunk is fine, you’d typically do it to test compatibility or preview new features which means you’re a professional and have a good internet connection |
Hi @adamziel 👋 Thanks a lot for your feedback earlier — really appreciate the clarification on the repo bloat and performance trade-offs.
Thanks again for your guidance! |
Fixes #1763
This PR replaces the existing Nightly WordPress version option in the Playground UI with Trunk, which downloads directly from the wordpress/wordpress trunk branch.
What’s Changed
wp: "https://github.com/WordPress/WordPress/archive/refs/heads/trunk.zip"
Why Replace Nightly with Trunk?
Testing Instructions
Video:
REC-20250411173336.mp4