Skip to content

feat(combobox): adding new s2 migration #3683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: spectrum-two
Choose a base branch
from

Conversation

aramos-adobe
Copy link
Contributor

Description

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: fb54e14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aramos-adobe aramos-adobe self-assigned this Apr 23, 2025
@aramos-adobe aramos-adobe marked this pull request as draft April 23, 2025 16:30
@aramos-adobe aramos-adobe added the S2 Spectrum 2 label Apr 23, 2025
Base automatically changed from aramos-adobe/css770-infield-button-s2-migration to spectrum-two April 24, 2025 15:58
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

markdownlint-fix

[markdownlint-fix] reported by reviewdog 🐶

"--spectrum-gray-50",
"--spectrum-gray-700",
"--spectrum-gray-800",


[markdownlint-fix] reported by reviewdog 🐶

"--spectrum-negative-color-1100",


[markdownlint-fix] reported by reviewdog 🐶

"--spectrum-neutral-background-color-selected-default",
"--spectrum-neutral-background-color-selected-down",
"--spectrum-neutral-background-color-selected-hover",
"--spectrum-neutral-background-color-selected-key-focus",


[markdownlint-fix] reported by reviewdog 🐶

"--spectrum-text-to-control-100",


[markdownlint-fix] reported by reviewdog 🐶

"--highcontrast-checkbox-color-hover",


[markdownlint-fix] reported by reviewdog 🐶

"--highcontrast-checkbox-highlight-color-focus",

Copy link
Contributor

github-actions bot commented Apr 24, 2025

File metrics

Summary

Total size: 1.38 MB*
Total change (Δ): 🔴 ⬆ 0.16 KB (0.01%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Minified Gzipped Δ
combobox 26.06 KB 25.04 KB 2.97 KB 🟢 ⬇ 2.01 KB
helptext 7.05 KB 6.75 KB 1.15 KB 🔴 ⬆ 0.12 KB

File change details

combobox

Filename Head Minified Gzipped Compared to base
index.css 26.06 KB 25.04 KB 2.97 KB 🟢 ⬇ 2.01 KB
metadata.json 15.67 KB - - 🟢 ⬇ 0.20 KB

helptext

Filename Head Minified Gzipped Compared to base
index.css 7.05 KB 6.75 KB 1.15 KB 🔴 ⬆ 0.12 KB
metadata.json 3.87 KB - - 🔴 ⬆ 0.10 KB

tokens

Filename Head Minified Gzipped Compared to base
css/dark-vars.css 46.64 KB - - -
css/global-vars.css 76.23 KB - - -
css/index.css 250.43 KB - - 🔴 ⬆ 0.08 KB
css/large-vars.css 41.29 KB - - 🔴 ⬆ 0.04 KB
css/light-vars.css 46.62 KB - - -
css/medium-vars.css 41.41 KB - - 🔴 ⬆ 0.04 KB
json/tokens.json 388.37 KB - - -
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Apr 24, 2025

🚀 Deployed on https://pr-3683--spectrum-css.netlify.app

@aramos-adobe aramos-adobe force-pushed the aramos-adobe/css769-combox-s2-migration branch from a986db0 to ff02395 Compare April 24, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S2 Spectrum 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant