Skip to content

fix(button,statuslight,picker,etc): address regressions in migrated components #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/breezy-impalas-push.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"@spectrum-css/switch": patch
---

### S2 switch fixes

This work addresses minor regressions in the Switch component. Animation tokens are reimplemented and their usage updated within the style definitions.

Reference:

- [S2 switch migration](https://github.com/adobe/spectrum-css/pull/2651)
7 changes: 7 additions & 0 deletions .changeset/cute-pillows-stand.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@spectrum-css/statuslight": patch
---

### S2 status light fix

This work removes the reference to `default-font-family` in favor for `sans-font-family-stack` to ensure the status light's font renders appropriately for web.
7 changes: 7 additions & 0 deletions .changeset/fair-coins-buy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@spectrum-css/link": patch
---

### S2 link fix

This work adds the static color focus ring tokens to links (so that static white and static black links do _not_ have the usual blue focus ring).
7 changes: 7 additions & 0 deletions .changeset/fresh-spoons-try.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@spectrum-css/logicbutton": patch
---

### S2 logic button fix

Adds `border-style: solid` to the styles to avoid a 3D effect on the border.
7 changes: 7 additions & 0 deletions .changeset/late-worms-reply.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@spectrum-css/floatingactionbutton": patch
---

## S2 floating action button fix

Opts to use the color property as opposed to fill for the icon. This correctly passes the floating action button icon colors to the component, to override the fill property style that is set on the embedded `.spectrum-Icon`.
15 changes: 15 additions & 0 deletions .changeset/smart-spoons-sneeze.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed changesets ⭐

Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
"@spectrum-css/button": patch
---

### S2 button fixes

This work addresses some regressions noticed in the migrated S2 button. Mainly, the borders were gray where they were not supposed to be. Most of the changes are to ensure that the correct S2 tokens are being used appropriately in the styles and button follows the S2 design specs.

Additionally, there was some missing style support for the `.spectrum-Button--noWrap` option, so this work reimplements a "no wrapping" option for button components, and removes some of the repetitiveness in the no wrap test cases and story.

PRs used as reference:

- [S2 button migration](https://github.com/adobe/spectrum-css/pull/2600)
- [Add text wrapping option](https://github.com/adobe/spectrum-css/pull/3086)
- [PostCSS plugin updates/fixes](https://github.com/adobe/spectrum-css/pull/3502)
12 changes: 12 additions & 0 deletions .changeset/warm-loops-guess.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
"@spectrum-css/picker": patch
---

### S2 picker fixes

This work addresses some regressions noticed in the migrated S2 picker component. Mainly, S2 border colors were fixed (most of them are transparent, including disabled).

PRs used as reference:

- [Picker docs to storybook migration](https://github.com/adobe/spectrum-css/pull/3200)
- [S2 picker migration](https://github.com/adobe/spectrum-css/pull/2697)
25 changes: 8 additions & 17 deletions components/button/dist/metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
".spectrum-Button .spectrum-Icon",
".spectrum-Button .spectrum-Icon + .spectrum-Button-label",
".spectrum-Button .spectrum-ProgressCircle",
".spectrum-Button--noWrap .spectrum-Button-label",
".spectrum-Button--sizeL",
".spectrum-Button--sizeS",
".spectrum-Button--sizeS.spectrum-Button--iconOnly",
Expand All @@ -23,7 +24,6 @@
".spectrum-Button.spectrum-Button--accent .spectrum-Button-label",
".spectrum-Button.spectrum-Button--iconOnly",
".spectrum-Button.spectrum-Button--iconOnly .spectrum-Icon",
".spectrum-Button.spectrum-Button--iconOnly:after",
".spectrum-Button.spectrum-Button--negative",
".spectrum-Button.spectrum-Button--outline",
".spectrum-Button.spectrum-Button--primary",
Expand All @@ -35,7 +35,6 @@
".spectrum-Button.spectrum-Button--staticBlack.spectrum-Button--secondary",
".spectrum-Button.spectrum-Button--staticBlack.spectrum-Button--secondary.spectrum-Button--outline",
".spectrum-Button.spectrum-Button--staticWhite",
".spectrum-Button.spectrum-Button--staticWhite.is-selected",
".spectrum-Button.spectrum-Button--staticWhite.spectrum-Button--outline",
".spectrum-Button.spectrum-Button--staticWhite.spectrum-Button--secondary",
".spectrum-Button.spectrum-Button--staticWhite.spectrum-Button--secondary.spectrum-Button--outline",
Expand Down Expand Up @@ -91,6 +90,7 @@
"--mod-button-margin-block",
"--mod-button-margin-left",
"--mod-button-margin-right",
"--mod-button-max-inline-size",
"--mod-button-min-width",
"--mod-button-padding-label-to-icon",
"--mod-button-text-align",
Expand Down Expand Up @@ -131,7 +131,6 @@
"--spectrum-button-font-size",
"--spectrum-button-font-weight",
"--spectrum-button-height",
"--spectrum-button-icon-size-difference",
"--spectrum-button-intended-icon-size",
"--spectrum-button-line-height",
"--spectrum-button-min-width",
Expand Down Expand Up @@ -177,6 +176,7 @@
"--spectrum-component-top-to-workflow-icon-300",
"--spectrum-component-top-to-workflow-icon-75",
"--spectrum-corner-radius-full",
"--spectrum-disabled-background-color",
"--spectrum-disabled-border-color",
"--spectrum-disabled-content-color",
"--spectrum-disabled-static-black-background-color",
Expand All @@ -198,10 +198,8 @@
"--spectrum-gray-100",
"--spectrum-gray-200",
"--spectrum-gray-25",
"--spectrum-gray-300",
"--spectrum-gray-400",
"--spectrum-gray-50",
"--spectrum-gray-500",
"--spectrum-gray-600",
"--spectrum-gray-800",
"--spectrum-gray-900",
"--spectrum-icon-block-size",
Expand All @@ -218,10 +216,6 @@
"--spectrum-neutral-content-color-down",
"--spectrum-neutral-content-color-hover",
"--spectrum-neutral-content-color-key-focus",
"--spectrum-neutral-subdued-background-color-default",
"--spectrum-neutral-subdued-background-color-down",
"--spectrum-neutral-subdued-background-color-hover",
"--spectrum-neutral-subdued-background-color-key-focus",
"--spectrum-progress-circle-thickness-medium",
"--spectrum-sans-font-family-stack",
"--spectrum-static-black-focus-indicator-color",
Expand All @@ -230,21 +224,18 @@
"--spectrum-text-to-visual-200",
"--spectrum-text-to-visual-300",
"--spectrum-text-to-visual-75",
"--spectrum-transparent-black-1000",
"--spectrum-transparent-black-100",
"--spectrum-transparent-black-200",
"--spectrum-transparent-black-25",
"--spectrum-transparent-black-300",
"--spectrum-transparent-black-400",
"--spectrum-transparent-black-500",
"--spectrum-transparent-black-600",
"--spectrum-transparent-black-700",
"--spectrum-transparent-black-800",
"--spectrum-transparent-black-900",
"--spectrum-transparent-white-1000",
"--spectrum-transparent-white-100",
"--spectrum-transparent-white-200",
"--spectrum-transparent-white-25",
"--spectrum-transparent-white-300",
"--spectrum-transparent-white-400",
"--spectrum-transparent-white-500",
"--spectrum-transparent-white-600",
"--spectrum-transparent-white-800",
"--spectrum-transparent-white-900",
"--spectrum-white",
Expand Down
Loading
Loading