Skip to content

Moves non-main logic to its own package and update deps #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

poy
Copy link

@poy poy commented Jan 6, 2023

No description provided.

Copy link
Owner

@aertje aertje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the size and limited concern of the implementation I don't see any real benefit to moving effectively all of it into a separate package.
That said, I was planning to move the OIDC functionality into a separate package at some point to separate it from the emulator implementation. Perhaps then it would make sense to revisit this.

@aertje
Copy link
Owner

aertje commented Jan 22, 2023

Another thought: as it stands the docker-smoketests folder setup is broken; will have to move to a cmd folder structure and then your proposed change will probably be appropriate too.

@JIEHT9U
Copy link

JIEHT9U commented Jan 25, 2023

Hello, this PR is also very important for me because I'm going to use it as a library. And at the moment I can't do it because Golang doesn't allow to import code from the main package.

@aertje
Copy link
Owner

aertje commented Feb 16, 2023

I'm currently working on a more comprehensive restructure and update of this library and will include this: https://github.com/aertje/cloud-tasks-emulator/tree/v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants