Skip to content

Feature/7582 #7595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Feature/7582 #7595

wants to merge 6 commits into from

Conversation

Danthar
Copy link
Member

@Danthar Danthar commented Apr 10, 2025

Fixes #

Changes

Added a facility to provide your own supervision strategy that is used to govern the journal and snapshot-store plugins

This is a WIP. I need to probably add a configuration Spec, and some crash behavior tests at the very least.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Latest dev Benchmarks

not relevant

This PR's Benchmarks

not relevant

@Danthar
Copy link
Member Author

Danthar commented Apr 10, 2025

Although the way this supervision strategy configuration method will work. Sadly we dont enforce some kind of Init callback for our snapshot or journal implementations. If we did, we could force all implementations to handle their setup in there, stuff like initializing connections and whatnot. Then if that fails we could provide out of the box detection for init failures and use custom exceptions to explicitly communicate initialization failure.

But that would be a major breaking change for persistence plugin implementations.

@Danthar Danthar marked this pull request as draft April 11, 2025 07:43
@Danthar Danthar self-assigned this Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant