-
Notifications
You must be signed in to change notification settings - Fork 244
Add allure-pytest-log plugin for capture stdout content and attach to each step/test/fixture in report #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
b0322bc
to
68048d4
Compare
@sseliverstov Could you review it. Thanks |
@wuhuizuo, at first, it is awesome pr) Thanks! |
@wuhuizuo looks nice! Just one suggestion though: Because this seems to be already in the form of a separate plugin, couldn't it actually be packaged and distributed independently? Even uploading to PyPI to install like for example That way we can make this available to users to get some feedback even before needing to merge this into allure-framework repo. Then later, if it is really something to merge to allure-python, you wouldn't really need to monkey-patch anymore (e.g. |
@Sup3rGeo thank you for your suggestion!
|
I agree, so it could initially become something like allure-robotframework and allure-behave, and later on merge to allure-pytest. Let's hear from @sseliverstov |
Hi folks, I can't decide, what way is better, as a part of allure-pytest package or new one like a plugin. In my opinion, separated package is preferred, because it may be more than enhancement for allure-pytest plugin. I don't know how it apply now, but reusing code in behave and robot would be great. Current architecture is not able to provide well implemented plugin like this, you had saw that in monkey-pathched code. I need to some time for play around hooks infrastructure and implementation developer friendly decision. @wuhuizuo , I can't estimate how long would it, and if this code is need in pypi, you can distribute it from your repo. Btw, @Sup3rGeo's idea with log-to-step plugin might be implemented in this way. |
Hi all! I just wanted to point out that this feature is present in pytest-allure-adaptor. It would be nice to have it in this package too. |
@Sup3rGeo Sorry for responding late!
|
@wuhuizuo : Is your code in production? Is there a seperate package we need to install? |
@shreyashah |
is this PR going to be merged? |
Do we have any update here? |
//: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)
Context
Add pytest plugin: allure-pytest-log for capture stdout content and attach to allure report.
example:
After you have installed pip:
pytest-allure-log
, you can run with:Checklist