Topic/avoid separate mouse state #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plets. A couple bug fixes related to group colors.
This avoids extra state in the mouse rotation and tumble control. This also updates the slider values properly when mouse is used to rotate and tumble.
|
Thanks for looking at this @blacksound, this was on my todo list. I'll have to review some different cases, I remember there were some caveats related to how the mouse interaction behaved while animating. I should be able to get to this in a day or two. |
|
I have a different suggestion with the animation part. Not ready to push yet, but in short you could put the timed cycling outside i a separate routine that calls the model setters and manually refresh the userView. Will make a PR for that tomorrow. |
mtmccrea
force-pushed
the
master
branch
2 times, most recently
from
d6925f7 to
56dd45f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sliders does not update when rotation and tumble is set by mouse event from userView. This change cleans up the design a bit by having the mouse event callback call the model setters instead of the hidden mouse rotation/tumble state.
In order to have the rotation and tumble wrap naturally I have changed the ranges for the rotation and tumble sliders (PointViewRadianCtl instances in PointViewUI.sc.)