Skip to content

fix(card): title styles being overridden by global typography #10217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(card): title styles being overridden by global typography #10217

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 1, 2018

Fixes the card title styles potentially being overridden by the global .mat-typography styles if the title is set on a header node.

Fixes #10215.

@crisbeto crisbeto requested a review from jelbourn as a code owner March 1, 2018 19:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 1, 2018
jelbourn
jelbourn previously approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release and removed pr: needs review labels Mar 1, 2018
@jelbourn
Copy link
Member

jelbourn commented Mar 1, 2018

Caretaker note: this might affect people's overrides.

@crisbeto crisbeto force-pushed the 10215/card-title-typography branch from 745c607 to 2b9d944 Compare March 2, 2018 21:06
@andrewseguin
Copy link
Contributor

This ended up with quite a bit of screenshot diff failures internally - will take more time than we have to fix them and get approvals. This will likely have to wait until v7

@andrewseguin andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Mar 20, 2018
@josephperrott josephperrott added G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround labels Sep 20, 2018
@ngbot
Copy link

ngbot bot commented Sep 21, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@mmalerba
Copy link
Contributor

We're probably not going to be able to get this in for 7.0

@mmalerba mmalerba removed the P2 The issue is important to a large percentage of users, with a workaround label Sep 21, 2018
@crisbeto crisbeto force-pushed the 10215/card-title-typography branch from 2b9d944 to b081b09 Compare October 7, 2018 14:36
@crisbeto crisbeto added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Oct 18, 2018
@josephperrott josephperrott added blocked This issue is blocked by some external factor, such as a prerequisite PR and removed action: merge The PR is ready for merge by the caretaker presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged labels Oct 19, 2018
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 30, 2019
@crisbeto
fix(card): title styles being overridden by global typography
9662e81 
Fixes the card title styles potentially being overridden by the global `.mat-typography` styles if the title is set on a header node.

Fixes angular#10215.
@crisbeto crisbeto force-pushed the 10215/card-title-typography branch from b081b09 to 9662e81 Compare June 30, 2019 09:15
@Totati
Copy link
Contributor

Totati commented Oct 7, 2019 •
edited
Loading

V9 is comming. I hope after mdc debuting this and all the mess around mat-typography will be fixed too.

@crisbeto crisbeto mentioned this pull request May 3, 2020
Closed
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@crisbeto crisbeto mentioned this pull request Apr 17, 2021
Open
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@andrewseguin andrewseguin removed the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Mar 28, 2022
@josephperrott josephperrott added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed needs rebase labels Nov 16, 2022
@mmalerba mmalerba self-assigned this Nov 28, 2022
@mmalerba
Copy link
Contributor

Closing since this fix is for the legacy mat-card which has been superseded by the MDC based one.

@mmalerba mmalerba closed this Nov 28, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

Assignees

@mmalerba mmalerba

Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews blocked This issue is blocked by some external factor, such as a prerequisite PR cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

matCardTitle overridden by h2 styles
7 participants
@crisbeto @jelbourn @andrewseguin @mmalerba @Totati @googlebot @josephperrott