fix(material/autocomplete): mark control as touched once panel is closed #18318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
|
Caretaker note: this changes the order of events slightly which has the potential to break tests. We should evaluate how to proceed based on the presubmit results. |
jelbourn
added
pr: lgtm
action: merge
|
SIGH There are 110 failing targets. Half of them are build errors like this, and the other half are test failures due to the behavior change. We've got to get people using the harnesses. |
jelbourn
added
the
presubmit failures
crisbeto
force-pushed
the
18313/autocomplete-touched-blur
branch
from
808a3a5 to
54bdaa3
Compare
|
I've put back the two functions so at least the compilation issues are resolved. |
crisbeto
force-pushed
the
18313/autocomplete-touched-blur
branch
from
54bdaa3 to
71331d0
Compare
crisbeto
changed the title
crisbeto
force-pushed
the
18313/autocomplete-touched-blur
branch
from
71331d0 to
97d0d86
Compare
crisbeto
force-pushed
the
18313/autocomplete-touched-blur
branch
from
97d0d86 to
0884dcc
Compare
andrewseguin
added
needs rebase
and removed
cla: yes
crisbeto
force-pushed
the
18313/autocomplete-touched-blur
branch
from
0884dcc to
2c7ce85
Compare
crisbeto
removed
needs rebase
presubmit failures
crisbeto
force-pushed
the
18313/autocomplete-touched-blur
branch
from
2c7ce85 to
1d23c86
Compare
crisbeto
force-pushed
the
18313/autocomplete-touched-blur
branch
from
1d23c86 to
f63b699
Compare
Currently we mark the autocomplete control as touched on `blur`. The problem is that the `blur` event happens a split second before the panel is closed which can cause the error styling to show up and disappear quickly which looks glitchy. These changes change it so that the control is marked as touched once the panel is closed. Also makes a couple of underscored properties private since they weren't used anywhere in the view. Fixes angular#18313.
crisbeto
force-pushed
the
18313/autocomplete-touched-blur
branch
from
f63b699 to
8806d31
Compare
andrewseguin
removed
the
P3
josephperrott
requested review from
amysorto and
mmalerba
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we mark the autocomplete control as touched on
blur. The problem is that theblurevent happens a split second before the panel is closed which can cause the error styling to show up and disappear quickly which looks glitchy. These changes change it so that the control is marked as touched once the panel is closed.Also makes a couple of underscored properties private since they weren't used anywhere in the view.
Fixes #18313.
Caretaker note: Change is problematic, lots of tests depend on programmatic blur events to mark a control as touched.