Fix(material/paginator): Table data does not get updated when paginat… #26903
Conversation
…or pageIndex is modified Fixes a bug in the Angular Material `paginator` component where table data does not get updated when paginator pageIndex is modified via Input. This is because pageEvent is not fired when pageIndex changes. Fixes angular#26890
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi. Could we get the changes soon? The changes looking good for me. |
There was a problem hiding this comment.
@andrewseguin correct me if I'm wrong here, but I believe the intent of this event is that we only emit it when the user performs an action that changes the page, not when its programmatically set
|
That's right - the paginator should only emit events when the user changes something. Otherwise there's a weird paradigm where Input changes directly emit Output events, and Im not sure we do that anywhere. Instead, we'll solve this with this change, which adds an API to the data source to let it know it should forcefully send data based on the latest state of the data/filter/paginator/sort: #30896 |
Fixes a bug in the Angular Material
paginatorcomponent where table data does not get updated when paginator pageIndex is modified via Input. This is because pageEvent is not fired when pageIndex changes.Fixes #26890