fix(multiple): use DI token for tag name #30892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
Reads the tag name through DI, instead of going through the DOM which should be more SSR-friendly.
crisbeto
force-pushed
the
tag-name-token
branch
from
1da99d5 to
4d2ab31
Compare
| // Heads-up for developers to avoid putting matBadge on <mat-icon> | ||
| // as it is aria-hidden by default docs mention this at: | ||
| // https://material.angular.io/components/badge/overview#accessibility | ||
| if ( | ||
| nativeElement.tagName.toLowerCase() === 'mat-icon' && | ||
| tagName.toLowerCase() === 'mat-icon' && | ||
| nativeElement.getAttribute('aria-hidden') === 'true' |
There was a problem hiding this comment.
Will this always return false in SSR because of this nativeElement.getAttribute check?
There was a problem hiding this comment.
Nah getAttribute works during SSR.
wagnermaciel
approved these changes
Apr 17, 2025
crisbeto
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads the tag name through DI, instead of going through the DOM which should be more SSR-friendly.