fix(cdk/dialog): provide proper shaped Directionality #30898
Merged
+28
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
requested review from
adolgachev and
wagnermaciel
and removed request for
a team
mmalerba
added
P2
crisbeto
reviewed
Apr 17, 2025
angular#30702 added a `valueSignal` property to `Directionality`, this PR adds it to the directionality provided by cdk-dialog as well.
mmalerba
force-pushed
the
cdk-dialog-dir
branch
from
e48778d to
a3edca0
Compare
crisbeto
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30702 added a
valueSignalproperty toDirectionality, this PR adds it to the directionality provided by cdk-dialog as well.