fix: Update apisix-grafana-dashboard.json #12100
Open
+19
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana decrepted all panels that made using angular panels and added react as base framework for new panels. due to that reason i edited this json file and updated new things for supporting react as base library
dosubot
bot
added
size:XS
alibabakhanlu12
changed the title
|
Hi @Baoyuantop, any chance to review the changes? |
Yes, I'm on it. |
Baoyuantop
reviewed
Apr 3, 2025
dosubot
bot
added
size:M
|
I changed the file’s indentation to 2 spaces, and now the changes are visible |
|
@Baoyuantop good to merge? |
Baoyuantop
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grafana has officially deprecated and removed support for Angular-based panels from Grafana 8.x onward. All new and existing panels now require React as the base framework.
Relevant Grafana documentation:
https://grafana.com/developers/plugin-tools/migration-guides/angular-react/
https://grafana.com/docs/grafana/latest/developers/angular_deprecation/
Description
This PR updates the existing Apache APISIX Grafana dashboard JSON to replace deprecated Angular-based panels with their React-based equivalents:
Singlestat → Stat
Graph → Time Series
Replaced "type": "singlestat" with "type": "stat".
Replaced "type": "graph" with "type": "timeseries".
Which issue(s) this PR fixes:
The current Apache APISIX Grafana dashboard uses panels that no longer function in Grafana v8.x and later due to Grafana’s removal of AngularJS support. Without migrating these panels, users encounter errors:
"This panel requires Angular support in Grafana."
This update resolves the issue by ensuring compatibility with current and future Grafana releases.
Checklist