VMware: match nic mac for ip address fetch #10641
Conversation
alexandru-bagu
force-pushed
the
fix-vmware-ip-loss
branch
from
f8296f2 to
d3939f0
Compare
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
| @@ -788,12 +793,6 @@ protected void runInContext() { | |||
| } | |||
| } | |||
| } else { | |||
| //previously vm has ip and nic table has ip address. After vm restart or stop/start | |||
There was a problem hiding this comment.
In my opinion, if we cannot know if the VM still has the IP assigned or not then we should not modify the database. In other words, we should be sure that the VM's NIC does not have an IP assigned before updating the database.
Interesting. I see your PR has more changes than this PR. Feel free to grab my code for VMware and close this PR. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12924 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10641 +/- ##
============================================
- Coverage 16.30% 16.30% -0.01%
+ Complexity 13448 13446 -2
============================================
Files 5674 5674
Lines 499203 499216 +13
Branches 60369 60373 +4
============================================
+ Hits 81408 81409 +1
- Misses 408726 408738 +12
Partials 9069 9069
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
weizhouapache
changed the title
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13098 |
|
@alexandru-bagu |
alexandru-bagu
force-pushed
the
fix-vmware-ip-loss
branch
from
d3939f0 to
2726aca
Compare
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
I rebased the changes onto 4.20 and changed merge target branch to 4.20. |
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
great, thanks @alexandru-bagu |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13179 |
Description
This PR fixes #10640
The main solution for the issue here would be to make sure that we are getting the IP for the correct NIC which we can do based on the MAC of the NIC. Additionally, a null IP is also a valid response because a NIC can have no IP assigned.
It's up for discussion whether we should pull any IP even if it does not match the network subnet because the user can in fact use the NIC with another subnet as well, but that is not necessarily relevant to this issue.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
I am in the process of testing on my dev environment then going to push in prod once I am happy with the results.
How did you try to break this feature and the system with this change?