ssvm: use mgmt network if no storage network #10735
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#10163 Based on apache#10163 (comment) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10735 +/- ##
=========================================
Coverage 15.17% 15.17%
- Complexity 11332 11335 +3
=========================================
Files 5415 5415
Lines 474893 474893
Branches 57920 57920
=========================================
+ Hits 72046 72054 +8
+ Misses 394792 394783 -9
- Partials 8055 8056 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13072 |
| @@ -2738,7 +2739,7 @@ public boolean configure(String name, Map<String, Object> params) throws Configu | |||
| _inSystemVM = true; | |||
| } | |||
|
|
|||
| _storageIp = (String)params.get("storageip"); | |||
| _storageIp = (String)ObjectUtils.firstNonNull(params.get("storageip"), _eth1ip); | |||
There was a problem hiding this comment.
the logic looks good to me
may use MapUtils
MapUtils.getString(params, "storageip", _eth1ip);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10163
Based on #10163 (comment)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?