-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ResourceCleanupService test fix for daylight saving time #10749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResourceCleanupService test fix for daylight saving time #10749
Conversation
@blueorangutan package |
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10749 +/- ##
=========================================
Coverage 16.02% 16.02%
- Complexity 13126 13131 +5
=========================================
Files 5652 5652
Lines 495998 495998
Branches 60067 60067
=========================================
+ Hits 79477 79491 +14
+ Misses 407653 407638 -15
- Partials 8868 8869 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test passed when days is 10 or 20.
another option could be
cal.setTimeZone(TimeZone.getTimeZone("UTC"));
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13102 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
@weizhouapache , you want to merge like this or amend? |
Description
This PR fixes ResourceCleanupService test for daylight saving time.
Fixes #10666
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Verified updated test.
How did you try to break this feature and the system with this change?