Skip to content

[WIP] feature: access logs in ui #10758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Apr 21, 2025

Description

WIP. More details to be added

This feature enables administrators to view management server logs directly in the UI through a dedicated API call. It leverages a Netty-based websocket server to stream logs in real time, offering an efficient way to monitor and debug server operations. Note that the plugin is disabled by default and must be enabled manually.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Logs-UI-Demo.mp4

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 2.20162% with 844 lines in your changes missing coverage. Please review.

Project coverage is 16.29%. Comparing base (576b97b) to head (4a9e4ae).

Files with missing lines Patch % Lines
...e/cloudstack/logsws/LogsWebSessionManagerImpl.java 4.69% 142 Missing ⚠️
...k/logsws/server/LogsWebSocketBroadcastHandler.java 0.00% 89 Missing ⚠️
...loudstack/logsws/LogsWebSessionApiServiceImpl.java 0.00% 85 Missing ⚠️
.../apache/cloudstack/logsws/vo/LogsWebSessionVO.java 0.00% 77 Missing ⚠️
.../cloudstack/logsws/server/LogsWebSocketServer.java 0.00% 56 Missing ⚠️
...e/cloudstack/logsws/dao/LogsWebSessionDaoImpl.java 0.00% 52 Missing ⚠️
...ack/logsws/server/LogsWebSocketRoutingHandler.java 0.00% 52 Missing ⚠️
...ck/logsws/api/response/LogsWebSessionResponse.java 0.00% 38 Missing ⚠️
.../api/response/LogsWebSessionWebSocketResponse.java 0.00% 31 Missing ⚠️
...om/cloud/cluster/ManagementServerHostDetailVO.java 0.00% 28 Missing ⚠️
... and 18 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10758      +/-   ##
============================================
- Coverage     16.31%   16.29%   -0.02%     
- Complexity    13464    13470       +6     
============================================
  Files          5676     5696      +20     
  Lines        499418   500421    +1003     
  Branches      60395    60473      +78     
============================================
+ Hits          81491    81558      +67     
- Misses       408855   409782     +927     
- Partials       9072     9081       +9     
Flag Coverage Δ
uitests 4.02% <ø> (+0.03%) ⬆️
unittests 17.15% <2.20%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bernardodemarco bernardodemarco self-requested a review April 21, 2025 18:05
This feature enables administrators to view management server logs directly in the UI through a dedicated API call. It leverages a Netty-based websocket server to stream logs in real time, offering an efficient way to monitor and debug server operations. Note that the plugin is disabled by default and must be enabled manually.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant