-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Ceph object store: Fix LocationConstraint error #10772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ceph object store: Fix LocationConstraint error #10772
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10772 +/- ##
============================================
+ Coverage 16.00% 16.02% +0.01%
- Complexity 13104 13129 +25
============================================
Files 5651 5652 +1
Lines 495862 496022 +160
Branches 60043 60065 +22
============================================
+ Hits 79367 79484 +117
- Misses 407635 407670 +35
- Partials 8860 8868 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@blueorangutan package |
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13181 |
@blueorangutan test |
@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
[SF] Trillian test result (tid-13167)
|
@rohityadavcloud @wido @DaanHoogland test failures are unrelated. Can we merge this? |
Yes, good to merge from my side |
good to merge if it has been tested by someone else than the author. (edit: these failures are happening on all branches and PRs atm) |
Description
This PR fixes #10044
Using
auto
as the signingRegion in AwsClientBuilder forces the s3 client to infer region from the url and set it as LocationConstraint while sending the request which is not required for ceph and causes the issue.requestRegion = AwsHostNameUtils.parseRegion(requestEndpoint.getHost(), "s3");
Location constraint was being set if the url starts with "s3." So a possible workaround if using this type of endpoint is to not use such kind of name for the endpoint url. Use some proxy or dns.
Have changed the code to pass null instead of auto which is resulting in LocationConstraint to not be set.
One more change is regarding the error msg which is returned while creating a bucket when the same bucket name is already present but created by another user.
Before:
Failed to create bucket with name: bucket2. AccessDenied (Service: Amazon S3; Status Code: 403; Error Code: AccessDenied; Request ID: tx00000610f7487f71ab177-00680a2196-ac4a-default; S3 Extended Request ID: ac4a-default-default; Proxy: null)
After:
Failed to create bucket with name: bucket2. Bucket already exists with the name: bucket2
This was because getBucketAcl doesn't work if the bucket was created by another user as the first user doesn't have Acl level access to the bucket.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?