Prevent data corruption for StorPool volumes #10799
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents data corruption in cases where a VM is started on a new host while it is already running on another host Scenario - if the host is down and the admin stops a VM with the option `force=true` the admin will be able to start it on another host. This may lead to a data corruption when the first host goes Up and the volume is attached on both hosts.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10799 +/- ##
============================================
- Coverage 16.42% 16.42% -0.01%
- Complexity 13549 13552 +3
============================================
Files 5673 5673
Lines 500080 500084 +4
Branches 60506 60507 +1
============================================
- Hits 82153 82148 -5
- Misses 408794 408804 +10
+ Partials 9133 9132 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rohityadavcloud
approved these changes
May 1, 2025
DaanHoogland
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents data corruption in cases where a VM is started on a new host while it is already running on another host
Scenario: If the host is down and the admin stops a VM with the option
force=true,the admin will be able to start it on another host. This may lead to data corruption when the issue with the first host is fixed, the volume will be attached to both hosts.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
Manual testing and with StorPool's smoke tests