[FLINK-36975][Connectors/AWS] Fix the AWS Config Option AWS_ROLE_CREDENTIALS_PROVIDER_OPTION to pick the right key #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ENTIALS_PROVIDER_OPTION to pick the right key
gguptp
approved these changes
Apr 5, 2025
leekeiabstraction
approved these changes
Apr 15, 2025
… for AWS Kinesis Stream sink
| * mock clients. | ||
| */ | ||
| @Internal | ||
| interface KinesisClientProvider { |
There was a problem hiding this comment.
Can this also extend SdkAutoCloseable so it's inline with the other resource impls?
Comment on lines
+210
to
+218
| if (kinesisClientProvider != null) { | ||
| // Use the provided client for testing | ||
| this.httpClient = null; | ||
| this.kinesisClient = kinesisClientProvider.get(); | ||
| } else { | ||
| // Create a new client as before | ||
| this.httpClient = AWSGeneralUtil.createAsyncHttpClient(kinesisClientProperties); | ||
| this.kinesisClient = buildClient(kinesisClientProperties, this.httpClient); | ||
| } |
There was a problem hiding this comment.
Nit: These can be pushed to their own constructors so you don't have to pass in null or do a null check.
| if (kinesisClientProvider != null) { | ||
| kinesisClientProvider.close(); | ||
| } else { | ||
| AWSGeneralUtil.closeResources(httpClient, kinesisClient); |
There was a problem hiding this comment.
IIUC, by having the provider extend SdkAutoCloseable, you can pass it as the last parameter to the util for resource cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
[FLINK-36975][Connectors/AWS] Fix the AWS Config Option AWS_ROLE_CREDENTIALS_PROVIDER_OPTION to pick the right key
https://issues.apache.org/jira/browse/FLINK-36975
Verifying this change
This change added tests and can be verified as follows:
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)
@Public(Evolving))