Skip to content

[hotfix] Update META-INF/NOTICE files #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darenwkt
Copy link
Contributor

Purpose of the change

Go through all the META-INF/NOTICE files and verify there are no missing dependencies:

  • Ran mvn dependency:tree -Dscope=compile to get a list of all dependencies
  • Narrow down the list by cross-checking POM file against which dependencies are actually included in shaded jar
  • Ran jar -tf to view content of jar to verify there are no missing dependencies as sanity check

flink-sql-connector-dynamodb

  • sorted dependency list
  • shaded org.apache.commons

flink-sql-connector-aws-kinesis-streams

  • sorted dependency list
  • updated POM to remove inclusion of com.typesafe.netty:* as it is not bundled in shaded jar

flink-sql-connector-aws-kinesis-firehose

  • sorted dependency list
  • updated POM to remove inclusion of com.typesafe.netty:* as it is not bundled in shaded jar

flink-sql-connector-kinesis

  • sorted dependency list

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Significant changes

(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)

  • Dependencies have been added or upgraded
  • Public API has been changed (Public API is any class annotated with @Public(Evolving))
  • Serializers have been changed
  • New feature has been introduced
    • If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant