Skip to content

KAFKA-18695: Remove quorum=kraft and kip932 from all integration tests #19633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mingyen066
Copy link
Collaborator

@mingyen066 mingyen066 commented May 4, 2025

Currently, the quorum uses kraft by default, so there's no need to
specify it explicitly.

For kip932 and isShareGroupTest, they are no longer used after #19542 .

Reviewers: PoAn Yang payang@apache.org, Ken Huang
s7133700@gmail.com, Chia-Ping Tsai chia7712@gmail.com

@github-actions github-actions bot added triage PRs from the community core Kafka Broker tools tests Test fixes (including flaky tests) labels May 4, 2025
@mingyen066 mingyen066 changed the title (WIP) KAFKA-18695: Remove quorum=kraft from all integration tests (WIP) KAFKA-18835: Remove quorum=kraft from all integration tests May 4, 2025
@mingyen066 mingyen066 changed the title (WIP) KAFKA-18835: Remove quorum=kraft from all integration tests (WIP) KAFKA-18695: Remove quorum=kraft from all integration tests May 4, 2025
@mingyen066 mingyen066 changed the title (WIP) KAFKA-18695: Remove quorum=kraft from all integration tests KAFKA-18695: Remove quorum=kraft from all integration tests May 4, 2025
Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the patch.

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingyen066 thanks for this patch. please add @Test and fix following cases too

def shouldReceiveOperationNotAttemptedWhenOtherPartitionHasError(quorum: String, version: Short): Unit = {

def testMetrics(quorum: String, systemRemoteStorageEnabled: Boolean): Unit = {

def testCreateRemoteTopicWithCopyDisabledAndDeleteOnDisable(quorum: String, copyDisabled: Boolean, deleteOnDisable: Boolean): Unit = {

Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mingyen066 for this patch, could you also update

  • kafka.api.MetricsTest#testMetrics
  • core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala#testCreateRemoteTopicWithCopyDisabledAndDeleteOnDisable

@FrankYang0529
Copy link
Member

Please replace @ParameterizedTest with @Test at all cases.

@mingyen066
Copy link
Collaborator Author

Thanks, @chia7712, @m1a2st and @FrankYang0529 . Changes have been made accordingly.

@github-actions github-actions bot removed the triage PRs from the community label May 6, 2025
@chia7712
Copy link
Member

the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-19243

@mingyen066 mingyen066 changed the title KAFKA-18695: Remove quorum=kraft from all integration tests KAFKA-18695: Remove quorum=kraft and kip932 from all integration tests May 10, 2025
@chia7712 chia7712 merged commit 57ae6d6 into apache:trunk May 11, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved core Kafka Broker tests Test fixes (including flaky tests) tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants