-
Notifications
You must be signed in to change notification settings - Fork 14.4k
KAFKA-18695: Remove quorum=kraft and kip932 from all integration tests #19633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-18695: Remove quorum=kraft and kip932 from all integration tests #19633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mingyen066 thanks for this patch. please add @Test
and fix following cases too
kafka/core/src/test/scala/unit/kafka/server/AddPartitionsToTxnRequestServerTest.scala
Line 58 in fedbb90
def shouldReceiveOperationNotAttemptedWhenOtherPartitionHasError(quorum: String, version: Short): Unit = { |
def testMetrics(quorum: String, systemRemoteStorageEnabled: Boolean): Unit = { |
def testCreateRemoteTopicWithCopyDisabledAndDeleteOnDisable(quorum: String, copyDisabled: Boolean, deleteOnDisable: Boolean): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mingyen066 for this patch, could you also update
kafka.api.MetricsTest#testMetrics
core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala#testCreateRemoteTopicWithCopyDisabledAndDeleteOnDisable
Please replace |
…ledAndDeleteOnDisable
Thanks, @chia7712, @m1a2st and @FrankYang0529 . Changes have been made accordingly. |
core/src/test/scala/unit/kafka/security/authorizer/AuthorizerTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/server/AddPartitionsToTxnRequestServerTest.scala
Show resolved
Hide resolved
the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-19243 |
Currently, the quorum uses kraft by default, so there's no need to
specify it explicitly.
For kip932 and isShareGroupTest, they are no longer used after #19542 .
Reviewers: PoAn Yang payang@apache.org, Ken Huang
s7133700@gmail.com, Chia-Ping Tsai chia7712@gmail.com